Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pevm: fallback to sequencial processor when the TxDAG is too deep #251

Conversation

andyzhang2023
Copy link
Contributor

@andyzhang2023 andyzhang2023 commented Jan 10, 2025

Description

A new option is added to improve the performance when the TxDAG contains a deep dependency chain. The performance might become poor when many transactions depend on each other in a block. So we add a threshold option under which the parallel EVM will be enabled, otherwise, the block will be processed by the original EVM in sequential.

Example

Add flag --parallel.txdag-max-depth-ratio to enable this feature. Default to be not enabled.

Copy link
Collaborator

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. just minor suggestion of the default threshold.

Copy link
Collaborator

@sunny2022da sunny2022da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the unit test

@sunny2022da sunny2022da merged commit dfab164 into bnb-chain:feature/TxDAG-PEVM Jan 13, 2025
1 check passed
sunny2022da pushed a commit to sunny2022da/op-geth that referenced this pull request Jan 14, 2025
andyzhang2023 added a commit to andyzhang2023/op-geth that referenced this pull request Jan 15, 2025
…b-chain#251)

Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants