-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pevm: fallback to sequencial processor when the TxDAG is too deep #251
pevm: fallback to sequencial processor when the TxDAG is too deep #251
Conversation
…dependencies is too deep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. just minor suggestion of the default threshold.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix the unit test
…lude' transactions
…b-chain#251) Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
…b-chain#251) Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
Description
A new option is added to improve the performance when the TxDAG contains a deep dependency chain. The performance might become poor when many transactions depend on each other in a block. So we add a threshold option under which the parallel EVM will be enabled, otherwise, the block will be processed by the original EVM in sequential.
Example
Add flag
--parallel.txdag-max-depth-ratio
to enable this feature. Default to be not enabled.